fix(android): align Glance component props#173
Merged
Conversation
Remove the unsupported CircularProgressIndicator progress prop from the Android widget surface and regenerate component bindings/docs.
Restore the Android TitleBar startIcon contract to match Glance and keep generated bindings and docs consistent.
Keep tintColor available as a backwards-compatible alias while also exposing Glance-style colorFilter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this?
This PR aligns the Android widget component surface with the Glance APIs it renders through. In particular,
CircularProgressIndicatorno longer exposes aprogressprop because Glance renders that component as indeterminate-only.How does it work?
The component schema and generated bindings now keep progress support on
LinearProgressIndicatoronly. The Android docs also describe circular progress as indeterminate without documenting an ignoredprogressoption.Why is this useful?
This prevents Android widget authors from passing a prop that cannot affect rendering, keeps generated types closer to runtime behavior, and makes the documentation clearer for status components.