Skip to content

fix(react): resolve plain props before the polymorphic as overload #1529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Anber merged 1 commit into from
Nov 5, 2026
Merged

fix(react): resolve plain props before the polymorphic as overload #1529

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/polymorphic-as-generic-spread.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@linaria/react': patch
---

Fix TypeScript inference for generic spread props on styled components (TS2698).
9 changes: 9 additions & 0 deletions packages/react/__dtslint__/styled-jsx.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,3 +9,12 @@ const Button = styled.button``;
<Button href="/" />;
// @ts-expect-error href is not a button property
<Button as="button" href="/" />;

declare function getProps<
T extends React.InputHTMLAttributes<HTMLInputElement>,
>(props?: T): T;

const Input = styled.input``;

// A spread of a generic call must not depend on the `as` overload.
<Input {...getProps()} disabled />;
5 changes: 5 additions & 0 deletions packages/react/src/styled.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,6 +273,11 @@ type IntrinsicElementProps<TName extends keyof IntrinsicElements> =
keyof IntrinsicElements extends TName ? unknown : IntrinsicElements[TName];

type StyledComponentWithAs<TProps> = {
// Tried first so that inference in JSX does not have to go through the generic `as` overload.
(
props: TProps & { as?: undefined },
context?: any
): ReturnType<React.FunctionComponent<TProps>>;
<TAs extends keyof IntrinsicElements>(
props: TProps & { as: TAs } & NoInfer<IntrinsicElementProps<TAs>>,
context?: any
Expand Down
Loading