Repository navigation
chore(deps): drop codecov, update del-cli to v8 and fix the tmp advisory - #1523
Merged
Anber merged 3 commits intoOct 23, 2026
Merged
Conversation
No script or workflow calls the codecov CLI, and the npm uploader is deprecated upstream. Dropping it removes codecov@3.8.3 and the packages only it needed from the lockfile. The README badge and .codecov.yml are kept.
Raise del-cli from ^1.1.0 to ^8.0.1 in the root and website manifests. del-cli 8 needs Node 22 or newer, which the repository already requires, and keeps the del and del-cli bins and positional paths, so the clean scripts are unchanged; each of them was run against the new version. The lockfile drops del@3 and its old dependency tree and adds del@9 with its dependencies. ignore is locked at 7.0.12 because 7.0.13 was published less than a week ago.
all-contributors-cli reaches tmp@0.0.33 through inquirer@7 and external-editor@3.1.0, which is affected by GHSA-52f5-9888-hmc6 and GHSA-ph9p-34f9-6g65 (fixed in tmp 0.2.6). No stable all-contributors-cli release moves off inquirer@7, and external-editor@3.1.0 is its latest version, so add a resolution for external-editor>tmp. An all-contributors-cli>tmp selector does not apply, since tmp is declared by external-editor. The lockfile now uses the tmp@0.2.7 it already had and drops tmp@0.0.33 and os-tmpdir. @changesets/cli also depends on external-editor@3.1.0, so the override repoints its tmp to 0.2.7 as well.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Three small dev-tooling items, one commit each. They touch only
devDependencies, oneresolutionsentry andpnpm-lock.yaml:codecovis a devDependency that nothing calls, and its lockfile entry is marked deprecated.del-cliis on 1.1.0 in two manifests; the current major is 8.tmp0.0.33 is reachable fromall-contributors-cliand@changesets/clithroughinquirerandexternal-editor. It is affected by GHSA-52f5-9888-hmc6 (tmp up to 0.2.3, low) and GHSA-ph9p-34f9-6g65 (tmp below 0.2.6, high).Nothing under
packages/,examples/orwebsite/src/changes, and no script is edited.Summary
The branch has three commits on top of
master. Three files differ frommaster:package.json,website/package.jsonandpnpm-lock.yaml.1.
chore(deps): remove the unused codecov devDependencyRemoves
"codecov": "^3.2.0"from the rootpackage.json, andcodecov@3.8.3from the lockfile together with the 12 packages only it needed.Why nothing is lost: no workflow step and no script calls it. A case-insensitive search of the tree finds
codecovonly in that devDependency line, in the lockfile, in the badge links ofREADME.mdand in.codecov.yml. The four workflows (check.yml,main.yml,release.yml,site-deploy.yml) have no coverage upload step. The only coverage script,"test:coverage": "turbo run test -- -- --coverage", passes a flag to the tests and does not call the package. The README badge links and.codecov.ymlare links and settings for the hosted service, so they stay as they are.2.
chore(deps): update del-cli to v8del-cligoes from^1.1.0to^8.0.1in the rootpackage.jsonand inwebsite/package.json, the same range in both.>=22; theenginesfloor of the repository is>=22.12.0and the CI matrix runs 22.x and 24.x. It ships the same two bins,delanddel-cli.clean(del 'packages/*/{coverage,dist,esm,lib,types,tsconfig.tsbuildinfo}') and, inwebsite/package.json,clean:client,clean:serverand the tail ofbuild:server(del-cli build-jsx).prebuildrunspnpm clean. They run unchanged on del-cli 8, so no script is edited. A search finds no other caller ofdelordel-cli.del3.0.0,meow3.7.0,update-notifier2.5.0 and what they pulled in) go, and 13 keys come in:del-cli8.0.1,del9.0.1,meow14.1.0,presentable-error0.0.1,globby16.2.4,fast-glob3.3.3,ignore7.0.12,is-path-cwd4.0.1,is-path-inside4.0.0,p-map7.1.1,slash5.1.0,unicorn-magic0.4.1 and@sindresorhus/merge-streams4.0.0.p-map7.1.1 (2026-10-11);del9.0.1 is from 2026-10-08 andignore7.0.12 from 2026-10-02.ignore7.0.13 was published on 2026-10-19, so it is not taken:globby16.2.4 acceptsignore^7.0.5, and 7.0.12 is the newest allowed version that is old enough.>=22(del-clianddel), which is below the 22.12.0 floor and both CI Node lines.3.
fix(deps): override tmp under external-editor to ^0.2.6Adds
"external-editor>tmp": "^0.2.6"to the rootresolutions, next to the two existing entries, and records it in theoverrides:header ofpnpm-lock.yaml.all-contributors-cli6.20.0 >inquirer7.3.3 >external-editor3.1.0 >tmp0.0.33.tmpis declared byexternal-editor, not byall-contributors-cli: anall-contributors-cli>tmpselector did not match, so the selector namesexternal-editor.all-contributors-cli, 6.26.1, still depends oninquirer^7.3.3; the only newer release is the prerelease 6.27.0-rc.1, which needs Node>=22.22.0, above the 22.12.0 floor.external-editor3.1.0 is its latest release and depends ontmp^0.0.33.tmp0.2.7 (published 2026-05-27), which the lockfile already had, so no newtmpentry is added.tmp0.0.33 andos-tmpdir1.0.2 leave the lockfile, and theexternal-editor@3.1.0snapshot is the only existing snapshot that changes.@changesets/clialso depends onexternal-editor3.1.0, so the override repoints itstmpto 0.2.7 as well. This is the same advisory.tmp0.2.7 is outside the^0.0.33range thatexternal-editordeclares. A round trip throughexternal-editor3.1.0 on the newtmp(edit('hello')with an editor script that appends a word) returnedhello edited, so its use oftmp.fileSyncworks.Lockfile scope and audit
pnpm-lock.yaml. Comparing it withmasteron the parsed keys:settingsare equal;overridesgains onlyexternal-editor>tmp;importerschange only by the removedcodecoventry and the twodel-clientries (specifier^1.1.0to^8.0.1, version 1.1.0 to 8.0.1, root andwebsite); 90 package keys are removed, 13 are added, and no other package changes version.masterto 28 in 35 on the branch. Four vulnerable entries disappear (tmp0.0.33,trim-newlines1.0.0,got6.7.1 and@tootallnate/once1.1.2) and none appears. The advisory database reports nothing for the 13 added versions or fortmp0.2.7.master:del-cli>del>globby>fast-glob/micromatch>braces3.0.3.braces3.0.3 (a stack exhaustion advisory on deeply nested brace patterns) has no patched release, and many other packages in the lockfile already reach it. Here it is a development tool that deletes fixed literal paths.Test plan
pnpm 9.15.9 (the version in the root
packageManagerfield) and Node 24.4.1, from the root of the branch:prebuildclean and thedel-cli build-jsxtail ofbuild:serverran on del-cli 8.0.1.typecheckran 19 of 19 tasks andtest:dts11 of 11;pnpm testran 11 of 11 with interop 7, core 4, react 22, postcss-linaria 100 and testkit 150 passed (2 skipped).--lockfile-onlymode with--strict-peer-dependencies. As a negative control, the manifests of the branch with the lockfile ofmasterfail withERR_PNPM_LOCKFILE_CONFIG_MISMATCHon theoverridesconfiguration.pnpm clean(thedistandesmsentinels ofpackages/coregone,packages/core/package.jsonkept;lib,types,coverageandtsconfig.tsbuildinfoof other packages removed as well),pnpm --filter linaria-website clean:client,clean:server,clean(whatprebuildruns, on an already clean tree) andexec del-cli build-jsx(the tail ofbuild:server). A realpnpm --filter linaria-website run build:serveralso exits 0 and leaves nobuild-jsx.grep -n -E '^ tmp@' pnpm-lock.yamllists onlytmp@0.2.7, andpnpm why tmp --recursiveshows only 0.2.7, including underexternal-editorfor bothall-contributors-cliand@changesets/cli.git grep -n -i codecov -- . ':!README.md' ':!.codecov.yml'prints nothing, and after the install nocodecovdirectory is innode_modules/.pnpm.Not verified
enginesfield of del-cli 8.0.1 (>=22) against the 22.12.0 floor, and the scripts only pass plain relative paths and one quoted glob.--ignore-scripts, so no lifecycle scripts of the new packages were run.tmp0.2.7 underexternal-editorwas exercised through a directedit()call only; I did not run theall-contributorsorchangesetCLIs interactively.pnpm-lock.yamlmay conflict with it textually.Changeset
None. The root package and
linaria-websiteare private, so the published output of the packages does not change.