perf: diagnose iOS snapshot latency jitter#920
Open
thymikee wants to merge 1 commit into
Open
Conversation
Size Report
Startup median (7 runs, lower is better):
Top changed chunks:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add bounded iOS snapshot timing diagnostics from the XCTest runner into
snapshotDiagnostics, including backend, phase, and selected-backend timing.Keep default snapshot output compact by capping retained samples and phase keys while surfacing larger evidence through debug diagnostics/session artifacts.
Refs #917
Validation
pnpm exec vitest run src/__tests__/snapshot-diagnostics.test.ts src/commands/capture/index.test.tspassed.pnpm check:quick,pnpm format,pnpm build, andpnpm build:xcuitestpassed.pnpm check:unitwas run twice; each full run had one unrelated flakysrc/utils/__tests__/daemon-client.test.tsfailure, and each failing test passed when rerun in isolation.Manual iOS simulator evidence on
iPhone 17 Pro Maxwith Settings: 4 Settings-rootsnapshot -i --json --debugsamples and 3 General-subpage samples succeeded, and the session was closed. The first root snapshot was 6486ms end-to-end while runner-reported snapshot work was 248ms; warm root snapshots settled around 121ms end-to-end with runner_total around 115ms, backend.tree around 86ms, and xctest_root_snapshot around 51ms. This points the observed cold jitter at runner/session lifecycle or daemon transport startup rather than accessibility traversal/shaping.