feat: support resumable proxy uploads#919
Open
thymikee wants to merge 2 commits into
Open
Conversation
|
Size Report
Startup median (7 runs, lower is better):
Top changed chunks:
|
Member
Author
|
Fallow is red on this branch. The blocking findings are in the upload/proxy changes:
Please run |
Member
Author
|
Re-reviewed the corrected head after the Fallow fix. Fallow is now green, all checks are passing, and I do not see a blocker in the resumable upload/proxy route changes. I checked the daemon upload preflight/direct/finalize route, proxy token rewriting, client resume/re-preflight behavior, and the provider/proxy tests. Residual risk is limited to the new upload surface relying on the covered live proxy install evidence. Labeled ready-for-human. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/upload/preflight,/upload/direct/:id, and/upload/finalize, including retry/resume after interrupted direct uploads before falling back to legacy/upload./upload/*surface. Scope: 12 touched files.Validation
Verified with TypeScript, lint, focused upload/proxy tests, CLI help tests, build, and the full unit/smoke equivalent.
pnpm check:unititself was blocked by Corepack registry signature verification, so I ran its underlying local commands:./node_modules/.bin/vitest run --project unitpassed 286 files / 2774 tests, andnode --test test/integration/smoke-*.test.tspassed 8 with 1 expected opt-in web smoke skip.Focused checks passed: upload client/proxy/daemon HTTP resumable tests,
src/utils/__tests__/args.test.ts,./node_modules/.bin/tsc -p tsconfig.json,./node_modules/.bin/oxlint . --deny-warnings, andpnpm build.Live proxy install evidence: installed
AgentDeviceTester.appthrough a proxy-started server onto iOS simulatoriPhone 17 Pro Maxascom.callstack.agentdevicelab, and installed an Android Expo test APK through the same proxy flow ontoPixel 9 Pro XL API 37ascom.callstack.agentdevicelab.