[elirangoshen]

Explanation of Change

This builds on the unmerged useOnyxState from the Onyx store work and targets feature/onyx-store-useonyxstate-recut (Expensify#104690).

PERSONAL_AND_WORKSPACE_CARD_LIST is computed by OnyxDerived from CARD_LIST and every WORKSPACE_CARDS_LIST feed. It runs outside React and writes the merged list back into Onyx and to disk on every write to either key, even when nothing changed. All its consumers are Search surfaces.

This replaces the derived value with a usePersonalAndWorkspaceCardList hook on useOnyxState over the same two keys:

• The merge is memoized on its two inputs, so it runs once per write however many consumers are mounted, and an equal result returns the previous object.
• Each selector's output is kept per merged list and compared once, shared by all consumers. If it is equal, the previous object is returned.
• Because both steps keep the previous object for equal content, the hook compares outputs by identity. The default selectorEquality would otherwise deep-compare the full list again for every mounted consumer on every write.

All 7 consumers use the hook. The config, its key and its type are removed. The persisted row is left on disk, as with the TODOS removal. Neither key is redirected to the Search snapshot, so Search keeps reading live data.

A new reassure test mounts useSearchSections, useFilterFeedData, useFilterCardValue and useAdvancedSearchFilters 3 times each. 10 writes with 9,000 cards, mean ms:

Scenario	Base	This PR	Plain useOnyx
Write, unassigned cards change	829	368 (-56%)	446 (-46%)
Write, personal card renamed	890	641 (-28%)	646 (-27%)
Search surfaces render	146	19 (-87%)	65 (-55%)

With a normal number of cards the difference is 1 to 3 ms. On the iOS simulator (dev build, account with 21 cards), ManualOpenSearchRouter is 1946 ms on base and 1895 ms on this branch, which is within noise.

Fixed Issues

$ https://github.com/callstack-internal/expensify-issues/issues/3080
PROPOSAL:

Tests

1. Sign in to an account with a personal card and a workspace with a company card feed that has assigned cards.
2. Open Search and type card: in the search bar. Verify the autocomplete suggests your personal card and the workspace cards.
3. Open the Search filters. Verify the Card filter is shown, and that picking cards shows their names in the filter row.
4. Open the Feed filter. Verify the company card feed and the Expensify Card feed are listed.
5. Save a search with a card filter. Verify the saved search shows the card names.
6. Group expenses by card. Verify personal and workspace cards appear as before.
7. As a workspace admin, assign a new company card. Verify it shows up in the Card filter without a reload.

• Verify that no errors appear in the JS console

Offline tests

1. Go offline.
2. Open the Search filters and the Card filter. Verify your cards are still listed.
3. Go back online. Verify nothing changes.

QA Steps

Same as tests.

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If the PR adds or modifies the UI:
  • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
  • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
  • I verified all new/changed elements have meaningful accessible names and roles.
  • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari