Two bug fixes for sqlite3 database connector#31
Open
dm-coding wants to merge 2 commits intocakephp:masterfrom
Open
Two bug fixes for sqlite3 database connector#31dm-coding wants to merge 2 commits intocakephp:masterfrom
dm-coding wants to merge 2 commits intocakephp:masterfrom
Conversation
Member
There was a problem hiding this comment.
A test case is easier to read than an inline comment, and would help prevent a future regression.
Member
Is this point still relevant? if the config is invalid what should happen is to fail early so the developer can fix their config. I've created a seperate 1 line PR (#100) for the second point. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reported here: http://stackoverflow.com/questions/4779007/cakephp-and-sqlite-fatal-error-call-to-a-member-function-query-on-a-non-obje, here: http://stackoverflow.com/questions/7107996/fatal-error-call-to-a-member-function-query-on-a-non-object-in-var-www-likes, and here: http://stackoverflow.com/questions/7572091/error-while-trying-to-connect-to-sqlite3-database-from-cakephp
To reproduce: set $config['connect'] to an invalid value.
All the best,
Daniel