Repository navigation
fix: drop the agreement badge beside the maximum error - #524
Merged
Merged
Conversation
caitlon
added
type:bug
|
Automatic reviews are disabled for this repository. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The results screen showed two coloured labels derived from the same level: "High Confidence" on the Best Compromise card and "High agreement" beside the maximum error. The second one named the closeness of the mean and the median as agreement, which the user guides already say it is not.
Change
The label beside the maximum error is gone.
ResultsSection.tsxkeeps the number, the bar and the hint. Thedetail.agreementkeys leave both locales, and the hint now reads "How close the mean and the median are. The closer they are, the more precise the compromise." Theagreement_levelvalues in the API are unchanged.The guides name the label the screen shows.
docs/user/reading-the-result.mdanddocs/user/worked-example.mdsay High, Moderate or Low Confidence and state what the label measures.Verification
./scripts/ci/ci-local.sh fast: 3266 backend and 1235 frontend tests passed.npm run test:coverage: statements 98.8, branches 95.65, functions 98.21, lines 99.02.project-results-*visual baselines change with the layout and are refreshed from this PR's CI run. Not run locally: the E2E tier.Migrations
None.
Screenshots
The refreshed visual baselines in this PR show the new card.