fix: answer CORS OPTIONS without an API key - #148
Merged
Conversation
Browser extensions send a preflight OPTIONS request without Authorization. Serve 204 with CORS headers before auth so /v1 remains usable cross-origin, while GET/POST still require a key.
Owner
Author
|
1 |
…i2api-pr148-merge.94OiZo # Conflicts: # CHANGELOG.md # internal/api/server.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OPTIONSwith204before API-key auth so browser extensions can call/v1(#145).Originand allowAuthorization,Content-Type,x-api-key,X-CLI2API-Session, andX-Qoder-Account.401with CORS headers so the client can read the error.Test plan
go test ./internal/api/ -count=1 -run 'TestCORS|TestManagementRoutesRequireAPIKey|TestNamedAPIKeyCannotManage'OPTIONS /v1/chat/completionsno longer gets401POST /v1/chat/completionswithout a key is still401Closes #145