π‘οΈ Sentinel: [CRITICAL/HIGH] Fix command injection in toolExists#93
π‘οΈ Sentinel: [CRITICAL/HIGH] Fix command injection in toolExists#93
Conversation
Replaced `shell("/usr/bin/which \(tool)")` with a direct `Process` execution using `/usr/bin/env which`. This prevents command injection vulnerabilities that could arise from malicious or malformed `requiresTool` string interpolations.
Co-authored-by: acebytes <2820910+acebytes@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π¨ Severity: HIGH
π‘ Vulnerability: Command Injection in
toolExistswithinSources/Cacheout/Models/CacheCategory.swift. The function used string interpolation to inject thetoolvariable directly into ashell("/usr/bin/which \(tool)")wrapper.π― Impact: If
requiresToolis manipulated to contain spaces or shell metacharacters, it allows arbitrary command execution via/bin/bash -c.π§ Fix: Replaced the insecure shell wrapper with a direct
Foundation.Processexecution. The command/usr/bin/env whichis now invoked with arguments safely segregated from the executable path, neutralizing the injection point.β Verification: Swift code compiles, and testing on environment indicates secure parsing. Test suite script cannot run natively on the current container. Added learning to
.jules/sentinel.mdjournal.PR created automatically by Jules for task 16882059175438663628 started by @acebytes