Conversation
- Wrapped HStack in Button and applied contentShape(Rectangle()) to CategoryRow and NodeModulesRow - Added accessibilityElement(children: .combine) and accessibilityAddTraits - Improves touch/mouse target size and VoiceOver experience Co-authored-by: acebytes <2820910+acebytes@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
💡 What
Modified
CategoryRowandNodeModulesRowto make the entire row clickable instead of just the small checkbox.🎯 Why
Small hit targets (just the checkbox) make it difficult to quickly select/deselect multiple categories or directories using a mouse or trackpad. Wrapping the entire row provides a much more intuitive and generous hit target.
📸 Before/After
Before: Only the small checkbox circle was clickable.
After: Clicking anywhere on the row (including empty space) toggles the selection.
♿ Accessibility
Added
.accessibilityElement(children: .combine)and.accessibilityAddTraits(.isSelected)to the rows. This ensures VoiceOver reads the entire row content as a single button and correctly announces its selected state, vastly improving the experience for screen reader users.PR created automatically by Jules for task 15270610546967848342 started by @acebytes