⚡ Bolt: Batch @Published array updates in CacheoutViewModel#91
⚡ Bolt: Batch @Published array updates in CacheoutViewModel#91
Conversation
Batch array updates by using `map` instead of `for` loop property access. This avoids triggering SwiftUI re-renders for every single item mutation, drastically improving responsiveness when checking/unchecking items, especially node_modules which can contain many items. Co-authored-by: acebytes <2820910+acebytes@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
💡 What: Refactored array mutation logic within
CacheoutViewModelto map the arrays and re-assign them, rather than updating elements one by one via array indices in a for loop.🎯 Why: Mutating an item inside a
@Publishedarray of structs through a loop causes theobjectWillChangepublisher to fire for each iteration. For large sets of data, this causes extreme UI lag. Updating the array in a single batch operation removes the O(n) UI update overhead.📊 Impact: Massively improves UI responsiveness when using buttons like "Select All Safe", "Select Stale (30d+)", or toggling bulk selection, changing an operation that triggers many UI redraws into a single fast update.
🔬 Measurement: Launch the app, trigger a scan that finds many
node_modulesfolders, and click "Select All" or "Select Stale". The UI will now remain perfectly responsive instead of lagging while re-rendering the view hierarchy repeatedly.PR created automatically by Jules for task 17361483716667018044 started by @acebytes