⚡ Bolt: Prevent serialisation bottleneck by converting Scanner actors to structs#90
⚡ Bolt: Prevent serialisation bottleneck by converting Scanner actors to structs#90
Conversation
… to structs Co-authored-by: acebytes <2820910+acebytes@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What: Converted
CacheScannerandNodeModulesScannerfromactortostructand added explicit performance documentation.🎯 Why: Using an
actorto manage awithTaskGroupwhere child tasks invoke blocking methods onselfinadvertently serializes the tasks on the actor's context, destroying parallelism. Since these scanners are stateless components that only interact with thread-safe dependencies (FileManager.default),actorisolation is unnecessary. Changing them tostructs allows the recursive filesystem traversals and size calculations to run truly concurrently across multiple threads.📊 Impact: Drastically reduces scan time for deep hierarchies and large file systems by unlocking true hardware parallelism.
🔬 Measurement: Verify by running the application and observing the time taken to complete a full scan of all cache categories and node_modules directories; the duration should be noticeably shorter, particularly on systems with many files.
PR created automatically by Jules for task 6970769507282085271 started by @acebytes