Skip to content

🎨 Palette: Make list rows completely clickable#88

Open
acebytes wants to merge 1 commit intomainfrom
palette-make-list-rows-clickable-8535096326754270956
Open

🎨 Palette: Make list rows completely clickable#88
acebytes wants to merge 1 commit intomainfrom
palette-make-list-rows-clickable-8535096326754270956

Conversation

@acebytes
Copy link
Copy Markdown
Contributor

@acebytes acebytes commented Apr 5, 2026

💡 What

Modified CategoryRow.swift and NodeModulesSection.swift so the entire row is clickable rather than just the selection checkbox image.

🎯 Why

In the original design, users could only toggle selections by clicking directly on the checkmark/circle icon, which provided a narrow and frustrating hit target. Making the entire row interactive significantly improves usability.

📸 Before/After

(Visual change is interaction-only; the layout remains exactly the same.)

♿ Accessibility

  • Wrapped row contents natively in Button.
  • Removed nested button components.
  • Used .accessibilityElement(children: .combine) to consolidate the row information for screen readers into a single understandable block.
  • Synchronized the selection state correctly via .accessibilityAddTraits(item.isSelected ? .isSelected : []) to provide clear feedback.

PR created automatically by Jules for task 8535096326754270956 started by @acebytes

Wrapped `CategoryRow` and `NodeModulesRow` `HStack` components in a `Button`, making the entire row a hit target. Added `contentShape(Rectangle())` to allow clicking on empty space. Condenses VoiceOver reading by grouping contents with `.accessibilityElement(children: .combine)` and mapping selection states using `.accessibilityAddTraits`.

Co-authored-by: acebytes <2820910+acebytes@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant