Skip to content

πŸ›‘οΈ Sentinel: [HIGH] Fix command injection in toolExists#87

Open
acebytes wants to merge 1 commit intomainfrom
sentinel/fix-command-injection-10454670355606927541
Open

πŸ›‘οΈ Sentinel: [HIGH] Fix command injection in toolExists#87
acebytes wants to merge 1 commit intomainfrom
sentinel/fix-command-injection-10454670355606927541

Conversation

@acebytes
Copy link
Copy Markdown
Contributor

@acebytes acebytes commented Apr 5, 2026

🚨 Severity: HIGH
πŸ’‘ Vulnerability: Found a command injection vulnerability in toolExists within Sources/Cacheout/Models/CacheCategory.swift where user-controlled input (tool) was directly interpolated into a shell wrapper: shell("/usr/bin/which \(tool)").
🎯 Impact: If requiresTool dynamically passed to toolExists contained any shell metacharacters or spaces, it could execute arbitrary code, compromising the application process.
πŸ”§ Fix: Refactored toolExists to eliminate the shell execution entirely. It now explicitly spawns a Process calling /usr/bin/env with ["which", tool] passed cleanly as process arguments, bypassing any shell parsing.
βœ… Verification: Verified compilation and correctness. The toolExists check safely routes via the Process API avoiding shell evaluation.


PR created automatically by Jules for task 10454670355606927541 started by @acebytes

Replaced `bash -c` shell interpolation with direct `Process` execution.

Co-authored-by: acebytes <2820910+acebytes@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant