π‘οΈ Sentinel: [HIGH] Fix command injection in toolExists#87
π‘οΈ Sentinel: [HIGH] Fix command injection in toolExists#87
Conversation
Replaced `bash -c` shell interpolation with direct `Process` execution. Co-authored-by: acebytes <2820910+acebytes@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π¨ Severity: HIGH
π‘ Vulnerability: Found a command injection vulnerability in
toolExistswithinSources/Cacheout/Models/CacheCategory.swiftwhere user-controlled input (tool) was directly interpolated into a shell wrapper:shell("/usr/bin/which \(tool)").π― Impact: If
requiresTooldynamically passed totoolExistscontained any shell metacharacters or spaces, it could execute arbitrary code, compromising the application process.π§ Fix: Refactored
toolExiststo eliminate the shell execution entirely. It now explicitly spawns aProcesscalling/usr/bin/envwith["which", tool]passed cleanly as process arguments, bypassing any shell parsing.β Verification: Verified compilation and correctness. The
toolExistscheck safely routes via theProcessAPI avoiding shell evaluation.PR created automatically by Jules for task 10454670355606927541 started by @acebytes