Skip to content

🎨 Palette: Make category rows fully clickable and accessible#82

Open
acebytes wants to merge 1 commit intomainfrom
palette/category-row-accessibility-15174302763953371544
Open

🎨 Palette: Make category rows fully clickable and accessible#82
acebytes wants to merge 1 commit intomainfrom
palette/category-row-accessibility-15174302763953371544

Conversation

@acebytes
Copy link
Copy Markdown
Contributor

@acebytes acebytes commented Apr 4, 2026

💡 What
Wrapped the HStack in CategoryRow.swift with a Button to increase the hit area. Applied .contentShape(Rectangle()) so the row is fully interactive. Combined the inner text elements for screen readers.

🎯 Why
Previously, only the small checkbox icon was clickable. This made it difficult for users to interact with the list rows. Wrapping the entire row in a button provides a significantly better hit target and conforms to standard interaction paradigms.

📸 Before/After
Before: Clicking the empty space or text of a row did nothing.
After: Clicking anywhere in the row toggles the checkbox selection.

Accessibility
Combined the internal UI components of each row using .accessibilityElement(children: .combine) to produce a single VoiceOver element. Furthermore, .accessibilityAddTraits(result.isSelected ? [.isSelected] : []) explicitly surfaces the selected state to assistive technologies.


PR created automatically by Jules for task 15174302763953371544 started by @acebytes

Co-authored-by: acebytes <2820910+acebytes@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant