🎨 Palette: Improve list row hit targets and VoiceOver support#78
🎨 Palette: Improve list row hit targets and VoiceOver support#78
Conversation
Co-authored-by: acebytes <2820910+acebytes@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What
Wrapped the main
HStackinsideCategoryRowandNodeModulesRowwith aButtonto drastically increase the clickable hit area. Used.contentShape(Rectangle())to ensure the empty spacer areas are clickable, and addedaccessibilityElement(children: .combine)andaccessibilityAddTraitsto treat the row as a single screen-reader element rather than disjointed views.🎯 Why
Previously, only the small checkbox icon on the left was clickable, forcing users to be overly precise when selecting items. Furthermore, VoiceOver would read the checkbox button and the text metadata as completely separate elements, cluttering navigation. This standardizes the row behavior to match Apple's expected list row paradigms.
📸 Before/After
(No visual changes, purely structural/interaction changes)
♿ Accessibility
.accessibilityAddTraits(.isSelected)so screen readers correctly announce the state.PR created automatically by Jules for task 7799280668982570358 started by @acebytes