Skip to content

🎨 Palette: Improve list row hit targets and VoiceOver support#78

Open
acebytes wants to merge 1 commit intomainfrom
palette-swiftui-list-row-accessibility-7799280668982570358
Open

🎨 Palette: Improve list row hit targets and VoiceOver support#78
acebytes wants to merge 1 commit intomainfrom
palette-swiftui-list-row-accessibility-7799280668982570358

Conversation

@acebytes
Copy link
Copy Markdown
Contributor

@acebytes acebytes commented Apr 3, 2026

💡 What
Wrapped the main HStack inside CategoryRow and NodeModulesRow with a Button to drastically increase the clickable hit area. Used .contentShape(Rectangle()) to ensure the empty spacer areas are clickable, and added accessibilityElement(children: .combine) and accessibilityAddTraits to treat the row as a single screen-reader element rather than disjointed views.

🎯 Why
Previously, only the small checkbox icon on the left was clickable, forcing users to be overly precise when selecting items. Furthermore, VoiceOver would read the checkbox button and the text metadata as completely separate elements, cluttering navigation. This standardizes the row behavior to match Apple's expected list row paradigms.

📸 Before/After
(No visual changes, purely structural/interaction changes)

♿ Accessibility

  • VoiceOver now combines the row text and state into a single element.
  • Added .accessibilityAddTraits(.isSelected) so screen readers correctly announce the state.
  • Hit target width increased from ~24px to the entire row width.

PR created automatically by Jules for task 7799280668982570358 started by @acebytes

Co-authored-by: acebytes <2820910+acebytes@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant