fix: use platform.node() for Windows compatibility#45
Open
fix: use platform.node() for Windows compatibility#45
Conversation
ArrowSerializer was unconditionally imported at module load time, causing ImportError for users who install cachekit without the [data] extra (pyarrow). Changes: - Remove top-level ArrowSerializer import - Add lazy loading via _get_arrow_serializer() helper - Use __getattr__ for lazy attribute access - Update SERIALIZER_REGISTRY to use None placeholder - Fix benchmark_serializers and get_serializer_info to handle lazy loading gracefully Users can now: - pip install cachekit and use default serializers - pip install cachekit[data] to enable ArrowSerializer Fixes #41
os.uname() is not available on Windows, causing ImportError when importing cachekit. platform.node() is cross-platform and provides the same hostname information. Fixes #43
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
os.uname().nodenamewithplatform.node()os.uname()doesn't exist on Windows, breaking all importsTest plan
from cachekit import cacheworks on WindowsFixes #43