Cleanup handler on exception to fix memory leak #101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aned up properly to avoid a memory leak. Fixes #97
Collaborator
Author
|
hmm... that's the second time I've had a random CI failure from out of memory when building ameba 🤔 Could that be because we're targeting such an old version of Crystal? I say "old", but 1.10 was released in Oct 23, so only 2 years old really... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #97
Basically if there was some exception that happened during the handler setup, it would leave all of the dead connections and the pinger (possibly) running. This just ensures those also get cleaned up. This was a small edge case, so not a critical memory leak, but still valid case.