Repository navigation
fix(render): name the caveats an estimate actually has in the summary - #106
Merged
Merged
Conversation
The markdown and PR-comment caveat summary always listed three fixed examples (a price from another region, usage not provided, an attribute that could not be evaluated), even when every caveat was, say, an assumed instance count.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The caveat summary line in markdown output and PR comments always read "parts of this estimate rest on assumptions (a price from another region, usage not provided, an attribute that could not be evaluated)", whatever the caveats were. On c3x-demo#11 all 6 caveats are
assumed_count, and none of the three examples applied.It now lists the kinds present, in order of first appearance, in plain words. For example: "(an assumed instance count)". Unknown future codes fall back to the code itself.
TestCaveatKindsNamesWhatIsPresentchecks ordering, de-duplication and the fallback, and that every known code has a phrase.