Repository navigation
fix(graphql): default MAX_PRODUCTS_PER_REQUEST to 5000 - #73
Merged
Merged
Conversation
c3x pricing sync enumerates the catalog 5,000 products per request, and released CLIs treat a shorter page as the last one, so the 1,000 cap truncated every sync to its first page and broke c3x estimate --offline.
andreacappelletti97
force-pushed
the
fix/products-cap-5000
branch
from
September 29, 2026 17:52
7948e1e to
91a0b62
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#60 capped each request at 1,000 products.
c3x pricing syncenumerates the catalog withlimit:5000pages, and released CLIs treat a page shorter than 5,000 as the last one. So since that deploy, every sync kept only the first 1,000 products of each service and region, andc3x estimate --offlinepriced most resources at the $0 stub. I reproduced it: an m5.xlarge came out at $0 offline versus $140.16 live, and a synced us-east-1 cache had 4,455 prices instead of 22,364.limit:50.docker-compose.yml,.env.example, README and CHANGELOG. The ops: query cost limits, cheaper scrapes, GIN-served lookups, monitoring, backups #60 entry wrongly said the CLI was unaffected; it now sayspricing syncpages 5,000 at a time.Deploy note: the VPS
.envhas noMAX_PRODUCTS_PER_REQUESTline, so rebuilding picks up the new default. Alternatively, addMAX_PRODUCTS_PER_REQUEST=5000to.envand restart the API.