feat: add typo suggestions for types, contracts and top-level keywords - #3309
Open
R-Camacho wants to merge 8 commits into
Open
feat: add typo suggestions for types, contracts and top-level keywords#3309R-Camacho wants to merge 8 commits into
R-Camacho wants to merge 8 commits into
Conversation
- Introduce `SuggestionKeywords` to hold lists of keywords. - Add `suggestion_init()` to populate these lists. - Implement typo suggestions for: - Top-level declarations; - Base types; - Contract parameter names. - Move `damerau_levenshtein_distance` to `stringutils.c`. - Add `str_find_closest` to `stringutils.c`. - Add tests for implemented suggestions. Closes c3lang#1420 Signed-off-by: Tomás Lopes <tomasrlopes@tecnico.ulisboa.pt> Signed-off-by: Rodrigo Camacho <rodrigompcamacho@tecnico.ulisboa.pt> Co-authored-by: Rodrigo Camacho <rodrigompcamacho@tecnico.ulisboa.pt>
Collaborator
|
Pushed to 0.8.2 |
lerno
requested changes
Jun 13, 2026
Contributor
Author
|
Hi @lerno, thanks for the review! We have applied your suggestions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SuggestionKeywordsto hold lists of keywords.suggestion_init()to populate these lists.damerau_levenshtein_distancetostringutils.c.str_find_closesttostringutils.c.Closes #1420