fix(desktop): wizard freezes on Continue — rename colliding bridge const#358
Merged
Conversation
Once the preload actually loaded (previous commit), `window.omadia` exists as a NON-CONFIGURABLE global property created by contextBridge. wizard.js declared a top-level `const omadia = window.omadia`, and ECMAScript forbids a global lexical binding whose name matches a non-configurable global property: Uncaught SyntaxError: Identifier 'omadia' has already been declared That aborts the entire script, so no click handlers bind and "Continue" does nothing. Rename the local reference to `bridge` (with a comment so it isn't "fixed" back). loading.js was unaffected — it uses `window.omadia` directly. Verified on the packaged macOS .app via CDP: no SyntaxError, the script loads, and clicking Continue advances the wizard (step 0 → 1).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #357 (onboarding preload bundle, already merged). That fix made
window.omadiaactually load — which unmasked a second bug.Symptom
After entering an API key, "Continue" does nothing. Console shows:
Root cause
contextBridge.exposeInMainWorld('omadia', …)exposeswindow.omadiaas a non-configurable global property. wizard.js declared a top-levelconst omadia = window.omadia, and ECMAScript forbids a global lexical binding (const/let) whose name matches a non-configurable global property. The declaration throws at parse time, which aborts the entire script — so no click handlers ever bind and the wizard freezes on Continue.It only appeared now: before #357 the preload was broken, so
window.omadiadidn't exist and the collision couldn't happen.Fix
Rename the local reference to
bridge(with a comment so it isn't "fixed" back toomadia). loading.js was unaffected — it useswindow.omadiadirectly without a top-level binding.Verification
On the packaged macOS
.app, driven against the actual wizard via CDP:Platform-agnostic (no Windows-specific code). All three desktop builds are green (run 27938240201).