fix(privacy-guard): render masked columns in canvas_publish_rows datasetId publishes#326
Open
Weegy wants to merge 1 commit into
Open
fix(privacy-guard): render masked columns in canvas_publish_rows datasetId publishes#326Weegy wants to merge 1 commit into
Weegy wants to merge 1 commit into
Conversation
…setId publishes The real-world result path. PR #324 fixed v4_render_answer, but query result tables actually render via canvas_publish_rows with a server-resolved datasetId. There, cells were mapped as resolvedRow[skeletonColumn.fieldKey]; the agent's skeleton fieldKeys do not all match the dataset's real field paths (e.g. Odoo `name`/`partner_id`/`invoice_date_due`), so mismatched columns — including the masked ones — rendered empty, with no privacy badge. Generic, path-agnostic fix at the single data-plane boundary: - resolveDatasetForRender now returns each column's `classification`. - canvas_publish_rows (datasetId branch) derives the table columns from the resolved dataset: fieldKey = authoritative path, privacy = "guard-protected" iff sensitive-masked, label = humanized path fallback. - patchComposition uses those dataset columns when present: maps cells by the real paths (so masked values populate), preserves the agent's human labels by position, replaces the table's columns, and carries the privacy flag. Odoo many2one [id,"Name"] tuples now render the display name, not raw JSON. Agent-authored (non-datasetId) publishes are byte-for-byte unchanged. Fixes empty masked cells + missing guard badge for ALL datasetId canvas producers. Pairs with omadia-ui renderer (badge/highlight on column.privacy). Tests: new canvasPublishMaskedColumns + 209 relevant regression tests green (node 22); full build clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Result tables on Privacy-Shield turns rendered with empty masked columns and no guard badge (live-verified on Fly: "offene Debitorenrechnungen" → Rechnungsnummer/Kunde blank).
Root cause (proven by repro + Fly logs): the real path is
canvas_publish_rowswith a server-resolveddatasetId— NOTv4_render_answer(which #324 fixed).resolveDatasetForRenderreturns the real masked values keyed by the dataset's field path. ButpatchCompositionmapped cells asresolvedRow[skeletonColumn.fieldKey], and the agent's skeleton fieldKeys don't all match the real paths (Odooname/partner_id/invoice_date_duevs agent'sinvoice_number/customer_name/due_date) → mismatched columns render empty. Columns that happened to use real Odoo field names (invoice_date,amount_total) filled fine.Fix — generic, at the single data-plane boundary
resolveDatasetForRender(harness-plugin-privacy-guard) now returns each column'sclassification(sensitive-masked|safe-cleartext); type added toPrivacyResolvedDatasetinplugin-api.canvas_publish_rowsdatasetId branch (omadia-ui-orchestrator) derives the table columns from the resolved dataset:fieldKey= authoritative path,privacy:"guard-protected"iffsensitive-masked, humanized-path label fallback. Emitted asdata.columns.patchCompositionuses those columns when present: maps cells by the real paths (masked values now populate), preserves the agent's human labels by position, replaces the table columns, carries the privacy flag. Odoo many2one[id,"Name"]tuples render the display name (not raw JSON). Agent-authored (non-datasetId) publishes are unchanged.This fixes empty masked cells + the missing badge for all datasetId-based canvas producers, not just one path.
Pairs with
omadia-ui renderer (
feat/privacy-guard-result-display): shield badge in the column header + violet cell highlight oncolumn.privacy. SchematableColumn.privacyenum merged in #324.Tests
canvasPublishMaskedColumns.test.ts: masked column shows the real value, carriesguard-protected, agent label preserved by position, extra dataset column uses humanized label.Residual risk (flagged for live verification)
Label reconciliation is by position (dataset column i ↔ skeleton column i). FieldKeys/values are always correct (keyed by path); only the human label mapping is order-sensitive. Correct for the proven Odoo case; one live canvas check on the masked-invoice query recommended (this PR + Fly deploy → local UI re-test).