feat: raise maximum sample time from 600 s to 6000 s - #156
Merged
Merged
Conversation
Slow, inertial systems (e.g. heating with PD control) need a longer PID evaluation interval for the derivative term to be meaningful. Closes #155. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UrhppzJMscLjTBuiYfZtvA
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Raises the upper limit of the
Sample Timenumber entity from 600 s to 6000 s. With slow, inertial systems (for example a heating system on PD control), a 10-minute cap is too short for the derivative term to be useful. The reporter already runs with 6000 s by patching the integration locally.The coordinator reads
sample_timedirectly to set itsupdate_interval, so nothing else has to change. Existing installs keep their current value, and the default stays at 10 s.Closes #155
Type of change
fix:Bug fix (patch version bump)feat:New feature (minor version bump)feat!:/BREAKING CHANGE:Breaking change (major version bump)chore:/docs:/ci:Maintenance or documentation (no version bump)Checklist
feat:,fix:,chore:, etc.)devbranch (notmain, unless this is a hotfix)