Skip to content

fix: always persist calibration after sampling, not only when correction moves #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bvweerd merged 1 commit into from
Sep 27, 2026
Merged

fix: always persist calibration after sampling, not only when correction moves #198

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion custom_components/battery_controller/coordinator_optimization.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
CALIBRATION_NO_SOC_SOURCE,
CALIBRATION_NOT_DISPATCHED,
CALIBRATION_PLAN_NOT_EXECUTED,
CALIBRATION_SAMPLED,
CALIBRATION_STEP_INCOMPLETE,
CHARGE_CALIBRATION,
DISCHARGE_CALIBRATION,
Expand Down Expand Up @@ -2218,7 +2219,12 @@ def _update_battery_eff_calibration(
)
actual_delta = max(0.0, measured)

if calibration.record(planned_delta, actual_delta, "SoC delta"):
moved = calibration.record(planned_delta, actual_delta, "SoC delta")
# Always persist after a sample, not only when the correction moves.
# When the correction is at the cap (1.05) every new sample is added to
# the rolling window but never triggers a save, so the file on disk stays
# in the old raw_ratio format and is re-migrated on every restart.
if moved or calibration.last_result == CALIBRATION_SAMPLED:
self.hass.async_create_task(calibration.async_save())

def _update_charge_eff_calibration(
Expand Down
Loading