Repository navigation
Add native Mac Catalyst screenshot capture - #17
Merged
Merged
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 58d51d1a3b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The existing Mac listing images are iPad composites. Add a repeatable workflow that launches the actual Catalyst app and captures its login, channel list, and settings windows at native App Store dimensions.
Changes
DEBUG && targetEnvironment(macCatalyst). Release behavior remains unchanged.XCUIElement.screenshot()captures as XCTest attachments. Export them with Apple'sxcresulttool, then encode JPEG files outside the test sandbox, without filesystem exceptions, resizing, compositing, or reconstructed window chrome.Run with:
Testing
Swift syntax parsing, the existing CI routing suite, YAML parsing, ShellCheck for the workflow commands, and
git diff --checkpass locally.The native capture run passed at
bb6299d438c1a2b445836d1544b3c31e2b5a4206, including Release compilation, Debug compilation and launch, UI readiness, exact window dimensions, XCTest attachment export, and JPEG encoding. The downloaded artifact matches GitHub's SHA-256 digestfd8539c8ff9c405d7091825982e92af980d5d5c489f213ae379984d335a6dec2. Provenance records version 1.0.2 (24).Every JPEG decodes as 1280 x 800 RGB, without an alpha channel. Visual inspection confirms the genuine native login, channels, and settings views, no visible error state or private account details, and no Debug-only credential button in the login capture. Fixture captures establish native UI rendering and capture automation, not live-provider playback.
Routine PR CI passed at the same revision, covering iOS unit tests, iPhone UI smoke, Mac Catalyst and tvOS builds, Apple release tooling, Android tests and builds, Swift core, join page behavior, Vega, and PS5 validation. The manual-only native capture job is intentionally skipped in that run and verified separately above.