Skip to content

Add native Mac Catalyst screenshot capture - #17

Merged
bvolpato merged 8 commits into
mainfrom
bvolpato/native-mac-screenshots-20261113
Nov 13, 2026
Merged

bvolpato merged 8 commits into
mainfrom
bvolpato/native-mac-screenshots-20261113

Conversation

@bvolpato

@bvolpato bvolpato commented Nov 13, 2026 •

Copy link
Copy Markdown
Owner

Summary

The existing Mac listing images are iPad composites. Add a repeatable workflow that launches the actual Catalyst app and captures its login, channel list, and settings windows at native App Store dimensions.

Changes

  • Add a dedicated Catalyst UI-test target and scheme, preserving the existing iOS UI-test target.
  • Add an explicit capture-only window-geometry flag behind DEBUG && targetEnvironment(macCatalyst). Release behavior remains unchanged.
  • Select and verify a sufficiently large native display mode. Request a 1280 x 800 application window through Apple's public scene-geometry API and reject captures with unaccepted dimensions.
  • Preserve original XCUIElement.screenshot() captures as XCTest attachments. Export them with Apple's xcresulttool, then encode JPEG files outside the test sandbox, without filesystem exceptions, resizing, compositing, or reconstructed window chrome.
  • Use no fixture flag for the logged-out screen, so its image contains no Debug-only controls. Channel and settings captures use synthetic offline fixture data without private accounts or provider content.
  • Record source revision, marketing version, build number, logs, native results, and original attachments in the artifact. Document the capture command in the release guide.

Run with:

GH_CONFIG_DIR=/home/bruno/.config/gh-personal gh workflow run ci.yml --repo bvolpato/brutv --ref bvolpato/native-mac-screenshots-20261113 -f scope=macos-screenshots -f macos_marketing_version=1.0.2 -f macos_build_number=24

Testing

Swift syntax parsing, the existing CI routing suite, YAML parsing, ShellCheck for the workflow commands, and git diff --check pass locally.

The native capture run passed at bb6299d438c1a2b445836d1544b3c31e2b5a4206, including Release compilation, Debug compilation and launch, UI readiness, exact window dimensions, XCTest attachment export, and JPEG encoding. The downloaded artifact matches GitHub's SHA-256 digest fd8539c8ff9c405d7091825982e92af980d5d5c489f213ae379984d335a6dec2. Provenance records version 1.0.2 (24).

Every JPEG decodes as 1280 x 800 RGB, without an alpha channel. Visual inspection confirms the genuine native login, channels, and settings views, no visible error state or private account details, and no Debug-only credential button in the login capture. Fixture captures establish native UI rendering and capture automation, not live-provider playback.

Routine PR CI passed at the same revision, covering iOS unit tests, iPhone UI smoke, Mac Catalyst and tvOS builds, Apple release tooling, Android tests and builds, Swift core, join page behavior, Vega, and PS5 validation. The manual-only native capture job is intentionally skipped in that run and verified separately above.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-13T03:49:34.209910Z 58d51d1 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 58d51d1a3b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@bvolpato
bvolpato merged commit f470909 into main Nov 13, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant