Skip to content

enable teacher reports access in sidebar and routes - #54

Merged
buzz-code merged 3 commits into
buzz-code:mainfrom
yaely20:main
Jan 7, 2026
Merged

buzz-code merged 3 commits into
buzz-code:mainfrom
yaely20:main

Conversation

@yaely20

@yaely20 yaely20 commented Jan 6, 2026

Copy link
Copy Markdown
Contributor

No description provided.

Comment thread client/src/App.jsx Outdated
Comment on lines +141 to +142
<Route path="/percent-report-with-dates" element={<TeacherPercentReportWithDatesList />} />
<Route path="student/student-attendance" element={<TeacherStudentAttendanceList />} />

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

כולם צריכים להתחיל בלוכסן

Comment thread client/src/GeneralLayout.jsx Outdated
]
}),
({ permissions }) => (isStandardView(permissions)) && ({
({ permissions }) => ((isStandardView(permissions)) || (isTeacherView(permissions))) && ({

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

אני לא חושבת שנכון להשתמש פה ב isStandardView
עדיף כבר לבדוק שזה לא in lesson report only

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

השם של הקובץ הזה מכיל שגיאת כתיב

Comment on lines +11 to +13
return <TeacherGuard> <StudentAttendanceList {...props} filter={teacherFilter} /> </TeacherGuard>;


Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

למה יש פה 2 שורות ריקות?
למה אין שבירות שורה? הייתי מצפה שיהיה ב3 שורות נפרדות ולא אחת ארוכה, אותו דבר גם בקובץ השני

Comment thread client/src/GeneralLayout.jsx Outdated
]
}),
({ permissions }) => ((isStandardView(permissions)) || (isTeacherView(permissions))) && ({
({ permissions }) => ((!isInLessonReport(permissions)) || (isTeacherView(permissions))) && ({

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

למה את עושה פה 2 בדיקות?
ככה זה לא מספיק?
({ permissions }) => !isInLessonReport(permissions) && ({

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

נראה לי כן כדי להחזיר את זה לההתחלה -
permissions }) => ((isStandardView(permissions)) || (isTeacherView(permissions)
מכיון שבשינוי יש בעיה sourse
(עכשיו אני רק רואה) וגם ככה זה לא פותר את הבדיקה של isTeacherView

@buzz-code
buzz-code merged commit 8138504 into buzz-code:main Jan 7, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants