Skip to content

add ability to create multiple approved absences at once - #46

Merged
buzz-code merged 7 commits into
buzz-code:mainfrom
yaely20:main
Dec 30, 2025
Merged

buzz-code merged 7 commits into
buzz-code:mainfrom
yaely20:main

Conversation

@yaely20

@yaely20 yaely20 commented Dec 28, 2025

Copy link
Copy Markdown
Contributor

No description provided.

@buzz-code buzz-code left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

עבודה טובה, כמה הערות לטיפולך

Comment thread client/src/entities/known-absence.jsx Resolved
Comment thread client/src/entities/known-absence.jsx Resolved
Comment thread client/src/components/ActionButton.jsx Resolved
Comment thread client/src/components/ActionButton.jsx Resolved
Comment thread client/src/components/ActionButton.jsx Resolved
Comment thread client/src/components/ActionButton.jsx Resolved
Comment thread client/src/entities/known-absence.jsx Resolved
Comment thread client/src/components/ActionButton.jsx Outdated


export const ActionButton = ({ label, name, permissions }) => {
if (isApprovedAbsencesBulk(permissions)) return null;

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

בדיקת ההרשאות חייבת להיות אחרי כל הuse, אחרת זה יגרום לנפילות.
תעבירי שיהיה יותר מאוחר - בין notify ל handleSave

Comment thread client/src/components/ActionButton.jsx Resolved
Comment thread client/src/components/ActionButton.jsx Resolved
Comment thread client/src/components/ActionButton.jsx Resolved
Comment thread client/src/entities/known-absence.jsx Resolved
Comment thread client/src/components/ActionButton.jsx Resolved
@buzz-code
buzz-code merged commit 80f38fa into buzz-code:main Dec 30, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants