Repository navigation
refactor(server): drop commented-out export headers, unused test param, type getRows body - #267
Merged
Merged
Conversation
…m, type getRows body Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012GTictqecCYiBSiCMj1RKN
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of buzz-code/ops#60
Scope
Weekly conservative tech-debt pass. Server only, behavior-preserving. No route/DTO/schema/migration changes, no submodule edits.
Changes
server/src/entity-modules/att-report.config.ts: remove 2 commented-out export header lines (approvedAbsCount,sheetName).server/src/entity-modules/known-absence.config.ts:getRows(body: any)->getRows(body: { rows?: StudentDatesRow[] } | undefined).server/src/entity-modules/__tests__/attendance-cleanup-rule.config.spec.ts: drop unusedrulesparam frommakeReqhelper and its 3 call sites.Helpers added
None.
Tests
yarn test: before 130/130 suites, 1282 tests pass; after same.npx tsc --noEmit -p tsconfig.json: clean before and after.shared/components/crudContainers/__tests__/AdvancedSort.test.jsx(unrelated).Generated by Claude Code