Skip to content

refactor(server): drop commented-out export headers, unused test param, type getRows body - #267

Merged
buzz-code merged 1 commit into
mainfrom
claude/refactor-debt-2026-11-14
Nov 14, 2026
Merged

buzz-code merged 1 commit into
mainfrom
claude/refactor-debt-2026-11-14

Conversation

@buzz-code

Copy link
Copy Markdown
Owner

Part of buzz-code/ops#60

Scope

Weekly conservative tech-debt pass. Server only, behavior-preserving. No route/DTO/schema/migration changes, no submodule edits.

Changes

  • server/src/entity-modules/att-report.config.ts: remove 2 commented-out export header lines (approvedAbsCount, sheetName).
  • server/src/entity-modules/known-absence.config.ts: getRows(body: any) -> getRows(body: { rows?: StudentDatesRow[] } | undefined).
  • server/src/entity-modules/__tests__/attendance-cleanup-rule.config.spec.ts: drop unused rules param from makeReq helper and its 3 call sites.

Helpers added

None.

Tests

  • Server yarn test: before 130/130 suites, 1282 tests pass; after same.
  • Server npx tsc --noEmit -p tsconfig.json: clean before and after.
  • Client: no client files changed. Baseline run: 274/275 pass; 1 pre-existing failure is a timeout in submodule test shared/components/crudContainers/__tests__/AdvancedSort.test.jsx (unrelated).

Generated by Claude Code

…m, type getRows body

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012GTictqecCYiBSiCMj1RKN
@buzz-code
buzz-code merged commit 5287a71 into main Nov 14, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants