Repository navigation
refactor(server): clean unused imports/mocks in specs, drop needless any casts - #261
Merged
Merged
Conversation
… any casts Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012GTicrQTzEeoiZ5N4vLecC
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Small, behavior-preserving cleanup in
server/only. No endpoint, client or submodule changes. No roadmap entry (internal only).BaseEntityModule,DataSource,TypeOrmModule,getDataSourceToken,Test,teacherReportFile,BulkToPdfReportGenerator,Repository), unused shadowedmockRepositorydeclaration, and deadglobal.MockBaseEntityModuleexport + unused local inentities.module.spec.ts.student-by-year.config.ts,student-percent-report.config.ts: replaced(data[0] as any).headers = XwithObject.assign(data[0], { headers: X })(same runtime effect, noany).Checked, left alone
tsc --noUnusedLocalsis clean for non-test, non-migration src. Migrations untouched.anyindoAction(req, body)overrides must match the signature inserver/shared(separate repo), so unchanged.doActionswitch blocks differ too much to extract a helper safely. No new utilities added.Tests
cd server && npx jest: 130 suites, 1276 tests passed. Client untouched, client tests not run.Notes
Ops tracking:
buzz-code/opsnot accessible from this session, so no issue was linked.Generated by Claude Code