Repository navigation
Conversation
- Stop stuck external requests (Google Fonts links) from hanging Page.printToPDF and 500-ing bulk student report PDFs (incident: TimeoutError waiting for Page.printToPDF, 30000ms). - Retry once with a fresh browser on transient browser crashes. - Optional PDF_PRINT_TIMEOUT_MS env var to raise the print timeout. Fix: buzz-code/nra-server#89
Owner
Author
|
Closing: the nra-server fix (#89) is now merged into main, so this pointer to a branch-only commit (0619f38) is obsolete. A single submodule bump PR pointing at the merge commit will follow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps
server/sharedto 0619f38 (nra-server PR #89).Why
Incident 500 on
GET /student/report(bulkstudentReportCardReactPDF):Report markup embeds external Google Fonts
<link>stylesheets; when the container's network access hangs, those requests never settle andPage.printToPDFstalls until puppeteer's 30s default timeout kills the request.What the bump brings
Session closed/Target closed) retry once with a fresh browser.PDF_PRINT_TIMEOUT_MSenv var to raise the print timeout (default unchanged, 30000 ms). No config change required.Fixes buzz-code/ops#43