Repository navigation
fix(teacher-reported-today): show unreported lessons before first report of the day - #257
Merged
Merged
Conversation
…ort of the day Gaps were only added between reported lessons, so lessons skipped at the start of the day never showed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012GTicrCNicbrDMWQntTtNf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
withLessonGapsonly added "לא דווח" slots between two reported lessons, so lessons skipped before a class's first report of the day never showed.lastIndex >= 0guard: every unreported period before a reported one now gets a slot.Tests
client/src/utils/lessonGaps.test.js: 14/14 pass (new cases for before-first-report, nothing-after-last, report-before-first-period).Generated by Claude Code