Repository navigation
Round fractional absence counts on absence tracking page - #256
Merged
Merged
Conversation
Counts like 9.600000000000001 showed raw float sums; display them with at most one decimal. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012GTictnqhUF9xceB6t8spc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Absence counts are fractional, so the absence tracking page showed raw float sums like
9.600000000000001 מעל הסף. AddsformatNumber(max one decimal) and uses it for every count on the page: threshold labels, per-student unapproved/lessons/approved line, subject chips, drill-down table and absence dates, summary tile hint.Tests:
yarn test src/pivots/AbsenceTrackingList.test.jsx src/utils/absenceTracking.test.jspass, including newformatNumbertest.Generated by Claude Code