Repository navigation
fix(attendance-cleanup-rule): return active as boolean - #253
Merged
Merged
Conversation
…ue/false BooleanIntColumn maps to raw tinyint, so mysql2 returned 1/0 and the react-admin BooleanField rendered an empty cell. Use a boolean column (same tinyint(1) in MySQL, no schema change). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012GTicsQ8RQNnQxvSzB95x3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by הדסה · project thread
activewas declared withBooleanIntColumn(rawtinyint), so the API returned1/0. react-admin'sBooleanFieldrenders only real booleans, so the "פעיל" column was empty.Switched to
@Column('boolean', { name: 'active', default: true }), the same pattern asStudent.isActive. MySQL type staystinyint(1), so no migration is needed. The sweep'sactive: truefilter is unchanged.Tests:
jest src/jobs src/entity-modules/__tests__/attendance-cleanup-rule.config.spec.tspass.Generated by Claude Code