Repository navigation
fix(client): filter lesson/class pickers by year in dialogs without year field - #252
Merged
Merged
Conversation
…ear field Bulk edit dialogs (grade, att report by month, known absence), approve full days, bulk approve absences and the class attendance journal report had lesson/class reference inputs relying on a year taken from form data. These forms have no year field, so the year filter was dropped and records from all years were listed, showing the same lesson name several times. Add a static filter for the selected year. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012GTicrS5U95qpZsb6Z5n9s
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by הדסה · project thread
Fixes buzz-code/ops#40
Problem
filterByUserIdAndYeartakesyearfrom form data. Dialogs below have no year field, so year filter is dropped and lessons/classes from all years are listed (same lesson name repeated).Fix
Add static
filter={defaultYearFilter}(selected year) to lesson/class reference inputs in:Forms with
CommonYearInput(create/edit) and list filters unaffected.Test
cd client && yarn test: 46 suites, 262 tests pass.Generated by Claude Code