Skip to content

fix(client): filter lesson/class pickers by year in dialogs without year field - #252

Merged
buzz-code merged 1 commit into
mainfrom
claude/project-thread-ckuydv
Nov 1, 2026
Merged

buzz-code merged 1 commit into
mainfrom
claude/project-thread-ckuydv

Conversation

@buzz-code

Copy link
Copy Markdown
Owner

Requested by הדסה · project thread

Fixes buzz-code/ops#40

Problem

filterByUserIdAndYear takes year from form data. Dialogs below have no year field, so year filter is dropped and lessons/classes from all years are listed (same lesson name repeated).

Fix

Add static filter={defaultYearFilter} (selected year) to lesson/class reference inputs in:

  • Bulk edit: grade, att report by report month, known absence
  • Approve full days (class)
  • Bulk approve absences (class, lesson — had no filter at all)
  • Class attendance journal bulk report (lessons)

Forms with CommonYearInput (create/edit) and list filters unaffected.

Test

cd client && yarn test: 46 suites, 262 tests pass.


Generated by Claude Code

…ear field

Bulk edit dialogs (grade, att report by month, known absence), approve full
days, bulk approve absences and the class attendance journal report had
lesson/class reference inputs relying on a year taken from form data. These
forms have no year field, so the year filter was dropped and records from
all years were listed, showing the same lesson name several times.
Add a static filter for the selected year.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012GTicrS5U95qpZsb6Z5n9s
@buzz-code buzz-code self-assigned this Nov 1, 2026
@buzz-code
buzz-code merged commit d33d123 into main Nov 1, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants