Repository navigation
refactor(server): drop unused test imports and redundant any cast - #250
Merged
Merged
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012GTicqTwKXdZZzT1agUtXD
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Small, behavior-neutral cleanup in
server/srconly. No submodule changes, no HTTP/API changes, no new utilities.attendance-cleanup-rule.config.ts: drop redundantas anyonreq.parsed.extra; tsc passes.grade.config.spec.ts,student-by-year.config.spec.ts,student-klass.config.spec.ts: remove unused imports (Repository,EntityMetadata,DeepPartial).Reviewed, left alone
(entity: any) => entity.idindoActionof klass, student-klass, report-group, report-group-session and att-report-with-report-month. Removinganyfails tsc, because the genericT extends Entity | Xhas noid. Fixing it needs a shared type change.dbNameand imports in old migrations. Left as-is, since migrations are history.tsc --noUnusedLocals).Tests
tsc --noEmit: pass.jest: 127 suites, 1250 tests, all pass.Generated by Claude Code