Skip to content

refactor(server): drop unused test imports and redundant any cast - #250

Merged
buzz-code merged 1 commit into
mainfrom
claude/refactor-debt-2026-10-31
Oct 31, 2026
Merged

buzz-code merged 1 commit into
mainfrom
claude/refactor-debt-2026-10-31

Conversation

@buzz-code

Copy link
Copy Markdown
Owner

Scope

Small, behavior-neutral cleanup in server/src only. No submodule changes, no HTTP/API changes, no new utilities.

  • attendance-cleanup-rule.config.ts: drop redundant as any on req.parsed.extra; tsc passes.
  • grade.config.spec.ts, student-by-year.config.spec.ts, student-klass.config.spec.ts: remove unused imports (Repository, EntityMetadata, DeepPartial).

Reviewed, left alone

  • (entity: any) => entity.id in doAction of klass, student-klass, report-group, report-group-session and att-report-with-report-month. Removing any fails tsc, because the generic T extends Entity | X has no id. Fixing it needs a shared type change.
  • Unused dbName and imports in old migrations. Left as-is, since migrations are history.
  • Production code has no unused locals (tsc --noUnusedLocals).

Tests

  • Server tsc --noEmit: pass.
  • Server jest: 127 suites, 1250 tests, all pass.
  • Client: no changes, so client tests not run.

Generated by Claude Code

@buzz-code
buzz-code merged commit a3bc37d into main Oct 31, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants