Repository navigation
feat: sort teacher report status by lesson counts, filter by unreported; sticky pagination - #249
Merged
Merged
Conversation
…ed; sticky pagination Fixes buzz-code/ops#33, buzz-code/ops#34. Part of buzz-code/ops#32. - teacher_report_status / teacher_grade_report_status views: add reportedLessonsCount, notReportedLessonsCount and hasNotReportedLessons (migration generated against MySQL, zero diff after run, revert checked). - The reported / not reported lesson columns sorted by the comma-joined lesson names, where a teacher with none is NULL and sorts first ASC, so sorting by "not reported" listed fully-reported teachers first. They now sort by the counts, DESC on first click. - NullableBooleanInput filter on hasNotReportedLessons in both lists. - client/shared -> nra-client branch: sticky pagination row on desktop. - Roadmap entries. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AxGDngmD8yeYDDm3rcXX4n
Pin client/shared to nra-client main (e972801, merge of nra-client#74) and keep roadmap entries from both sides. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AxGDngmD8yeYDDm3rcXX4n
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes buzz-code/ops#33
Fixes buzz-code/ops#34
Fixes buzz-code/ops#32
Summary
teacher_report_statusandteacher_grade_report_status: addreportedLessonsCount,notReportedLessonsCount(COUNT(DISTINCT CASE …)onisReported) andhasNotReportedLessons(notReportedLessonsCount > 0).1793215235847-AddLessonCountsToTeacherReportStatus: generated against MySQL. The schema name goes throughdbName, following the existing view migrations.reportedLessonNames/notReportedLessonNames(comma-joined names). A teacher with none getsNULL, which MySQL sorts first ascending, so sorting by "not reported" listed fully-reported teachers first. The columns now sort by the counts, descending on the first click (sortByOrder="DESC").NullableBooleanInputonhasNotReportedLessons("יש שיעורים שלא דווחו") in both lists, plus its translation.client/shared→e972801(nra-clientmain, the merge of feat(list): keep pagination row sticky at the bottom on desktop nra-client#74): a sticky pagination row on desktop. This also picks up nra-client#72/Automated Phone Calls HLD #73, which have no consumer rows.Verification
typeorm:run, thentypeorm:generate --drreports "No changes in database schema were found".migration:revertfollowed by a re-run succeeds.notReportedLessonNames,ASCreturned the fully-reported teacher first (bug reproduced).notReportedLessonsCount,DESCreturns 3, 2, 1, 0.hasNotReportedLessonsset totruereturns the 3 teachers with unreported lessons;falsereturns the fully-reported one.main: client jest 262/262, server jest 1250/1250,tsc --noEmitclean.Generated by Claude Code