Skip to content

Refactor: shared getSelectedIds, unused-binding cleanup, bump shared libs - #242

Merged
buzz-code merged 5 commits into
mainfrom
claude/refactor-debt-2026-10-24
Nov 4, 2026
Merged

buzz-code merged 5 commits into
mainfrom
claude/refactor-debt-2026-10-24

Conversation

@buzz-code

@buzz-code buzz-code commented Oct 24, 2026 •

Copy link
Copy Markdown
Owner

Requested by הדסה · project thread

Scope

Behavior-preserving server refactor plus a shared-lib bump. No API, schema or migration changes.

  • DRY: the (await this.getManyByIds(req, getAsNumberArray(req.parsed.extra.ids))).map(e => e.id) pattern (klass, student-klass, report-group, report-group-session, att-report-with-report-month getOwnedIds) now calls BaseEntityService.getSelectedIds(req) from the shared server lib (nra-server#87). The local helper from the first version of this PR is removed.
  • Dead code: removed unused entityName prop from StudentRecordsTable (lessonSignaturePdfReport.tsx); unused key destructure in studentReportCardReact.tsx.
  • server/shared -> nra-server main 4c555b9 (adds getSelectedIds, configurable MCP consent text, one browser per bulk PDF report with a capped render queue).
  • client/shared -> nra-client main 510cf19 (standalone CI only; package.json lives in the submodule and is ignored by this app's Jest).
  • Supersedes chore: bump server/shared for PDF generation resilience (#89) #259 (same server/shared bump, older target).

Tests

  • Specs that mocked getManyByIds for the id lookup now mock getSelectedIds (its auth filtering is covered in the shared lib).
  • Server: tsc --noEmit clean, jest 130 suites / 1271 tests pass locally.

🤖 Generated with Claude Code

https://claude.ai/code/session_012GTicqEBaARTF3owzjFrQq

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01YcJKachbaAqM1u1cHJDwMf
…ared

Drops the local getSelectedIds helper in favour of
BaseEntityService.getSelectedIds from the shared server lib, and moves
both shared submodules to their current main (includes the bulk PDF
render queue fix).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012GTicqEBaARTF3owzjFrQq
@buzz-code buzz-code changed the title Refactor: getSelectedIds helper and unused-binding cleanup (server) Refactor: shared getSelectedIds, unused-binding cleanup, bump shared libs Nov 4, 2026
@buzz-code
buzz-code merged commit c8c2686 into main Nov 4, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants