Repository navigation
Refactor: shared getSelectedIds, unused-binding cleanup, bump shared libs - #242
Merged
Merged
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YcJKachbaAqM1u1cHJDwMf
…ared Drops the local getSelectedIds helper in favour of BaseEntityService.getSelectedIds from the shared server lib, and moves both shared submodules to their current main (includes the bulk PDF render queue fix). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012GTicqEBaARTF3owzjFrQq
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012GTicqEBaARTF3owzjFrQq
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by הדסה · project thread
Scope
Behavior-preserving server refactor plus a shared-lib bump. No API, schema or migration changes.
(await this.getManyByIds(req, getAsNumberArray(req.parsed.extra.ids))).map(e => e.id)pattern (klass, student-klass, report-group, report-group-session, att-report-with-report-monthgetOwnedIds) now callsBaseEntityService.getSelectedIds(req)from the shared server lib (nra-server#87). The local helper from the first version of this PR is removed.entityNameprop fromStudentRecordsTable(lessonSignaturePdfReport.tsx); unusedkeydestructure in studentReportCardReact.tsx.server/shared-> nra-server main4c555b9(addsgetSelectedIds, configurable MCP consent text, one browser per bulk PDF report with a capped render queue).client/shared-> nra-client main510cf19(standalone CI only; package.json lives in the submodule and is ignored by this app's Jest).server/sharedbump, older target).Tests
getManyByIdsfor the id lookup now mockgetSelectedIds(its auth filtering is covered in the shared lib).tsc --noEmitclean,jest130 suites / 1271 tests pass locally.🤖 Generated with Claude Code
https://claude.ai/code/session_012GTicqEBaARTF3owzjFrQq