Skip to content

fix(known-absence): join klass and lesson in export - #239

Merged
buzz-code merged 1 commit into
mainfrom
claude/dreamy-meitner-85nt3u
Oct 22, 2026
Merged

buzz-code merged 1 commit into
mainfrom
claude/dreamy-meitner-85nt3u

Conversation

@buzz-code

Copy link
Copy Markdown
Owner

Summary

known-absence.config.ts → processReqForExport replaced the query joins with student and absenceType only. Two consequences:

  • The exported "כיתה" and "שיעור" columns (klass.name, lesson.name) come out empty.
  • Exporting the list while it is sorted by "כיתה" or "שיעור" fails with 400 Invalid field: klass.name. This happens with a plain header sort too, not only with the new multi-level sort.

The fix adds klass and lesson (eager) to the export joins, matching the list's joins. The config spec is updated.

Verification

  • Reproduced with the real BaseEntityService on SQLite, using minimal entities with the same join shape:
    • Export joins as they are today, sorted by klass.name: BadRequestException: Invalid field: klass.name.
    • Export joins as they are today, sorted by id: rows come back with no klass (empty column).
    • With klass added: sorted by klass.name, rows come back with class names.
  • Config spec: 5/5 passing. tsc --noEmit is clean.

Generated by Claude Code

processReqForExport replaced the joins with student/absenceType only, so
the exported כיתה/שיעור columns (klass.name, lesson.name) came out empty,
and exporting a list sorted by כיתה or שיעור failed with
"Invalid field: klass.name".

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AxGDngmD8yeYDDm3rcXX4n
@buzz-code
buzz-code merged commit 2da080b into main Oct 22, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants