Repository navigation
fix(known-absence): join klass and lesson in export - #239
Merged
Merged
Conversation
processReqForExport replaced the joins with student/absenceType only, so the exported כיתה/שיעור columns (klass.name, lesson.name) came out empty, and exporting a list sorted by כיתה or שיעור failed with "Invalid field: klass.name". Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AxGDngmD8yeYDDm3rcXX4n
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
known-absence.config.ts→processReqForExportreplaced the query joins withstudentandabsenceTypeonly. Two consequences:klass.name,lesson.name) come out empty.400 Invalid field: klass.name. This happens with a plain header sort too, not only with the new multi-level sort.The fix adds
klassandlesson(eager) to the export joins, matching the list's joins. The config spec is updated.Verification
BaseEntityServiceon SQLite, using minimal entities with the same join shape:klass.name:BadRequestException: Invalid field: klass.name.id: rows come back with noklass(empty column).klassadded: sorted byklass.name, rows come back with class names.tsc --noEmitis clean.Generated by Claude Code