Repository navigation
feat: advanced sort dialog; teacher salary report sorts by klass order/type - #237
Merged
Merged
Conversation
…r/type - client/shared -> 173581a (nra-client branch claude/dreamy-meitner-85nt3u): "מיון" toolbar button with a multi-level sort dialog; the dataProvider sends every level to the server and to the Excel export. - teacher_salary_report: sortOptions for סדר כיתה (klass.order) and שיוך כיתה (klass.klassType.name); server joins klass.klassType (list and export) so the nested sort field passes validation. - Roadmap entry. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AxGDngmD8yeYDDm3rcXX4n
Resolve client/shared to bb489e2 (sort branch merged with nra-client main) and keep the roadmap entries from both sides. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AxGDngmD8yeYDDm3rcXX4n
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AxGDngmD8yeYDDm3rcXX4n
Merge of nra-client#67 (advanced sort dialog); also picks up #68 (ops-tracking skill, docs only). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AxGDngmD8yeYDDm3rcXX4n
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A customer asked to see kodesh teachers first, then specialization teachers, and to sort by specialization.
client/shared→b95a332(nra-clientmain, the merge of feat(list): advanced multi-level sort dialog nra-client#67). This adds the "מיון" multi-level sort dialog to everyCommonList. The dataProvider sends every level to the list query and to the Excel/PDF/JSON export.teacher-salary-report.jsx):sortOptionsfor "סדר כיתה" (klass.order) and "שיוך כיתה" (klass.klassType.name).teacher-salary-report.config.ts): joinsklass.klassTypefor the list and the export, so the nested sort field passesBaseEntityServicevalidation. The config spec is updated.Verification
main: client jest 250/250, server jest 1195/1195,tsc --noEmitclean.extra.format=excel|pdf|json&sort[0]=name,ASC&sort[1]=tz,DESC.🤖 Generated with Claude Code
https://claude.ai/code/session_01AxGDngmD8yeYDDm3rcXX4n