Repository navigation
feat: approve absences by student and date range - #231
Merged
Merged
Conversation
Adds a shared known_absence action that finds a student's absences in a date range (optional klass) and creates approved known absences per lesson, skipping lesson+date pairs already approved. Exposed via a 'by student' tab on the approved absences upload screen (Excel: tz, klass, date, to-date) and an 'approve full days' dialog on the known absences list. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01D9Di6MyvoQ27N7fco8rxhw
buzz-code
marked this pull request as ready for review
October 19, 2026 05:43
Found while testing against a real database: - The approved absences upload's settings form never reached state (react-admin Form onChange receives the DOM event), so reason, sender and comment were always saved empty, in both tabs. - Text dates like 10/03/2026 were parsed as US month-first. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01D9Di6MyvoQ27N7fco8rxhw
Resolve roadmap conflict: replace the in-progress entry for this feature with the done entry. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01D9Di6MyvoQ27N7fco8rxhw
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by הדסה · project thread
Fixes buzz-code/ops#5
Before: approving a student's full-day absence meant entering a known absence for each lesson. The approved absences upload screen worked only by class + date.
After: the known absences list has an "אישור ימים מלאים" dialog (student, from/to date, optional class, reason). The approved absences upload screen has a "לפי תלמידה" tab that takes an Excel file with student ID, class (optional), date and to-date (optional), shows a preview, and approves. Both create one approved known absence per reported absence (per lesson) of the student in that range.
Lesson + date pairs that already have an approved known absence are skipped, so re-uploading the same file does not create duplicates.
How: new
previewByStudentDates/approveByStudentDatesactions onknown_absence(service inknown-absence.config.ts), logic inserver/src/utils/approveAbsencesByStudentDates.util.ts. Student ID is matched raw and padded to 9 digits, since Excel drops leading zeros. The class filter applies to the att_report's klass.Tests: new util spec; server entity-module and client jest suites pass;
tscandvite buildpass.Generated by Claude Code