Skip to content

Refactor: remove commented-out code blocks - #222

Merged
buzz-code merged 1 commit into
mainfrom
claude/refactor-debt-2026-10-17
Oct 17, 2026
Merged

buzz-code merged 1 commit into
mainfrom
claude/refactor-debt-2026-10-17

Conversation

@buzz-code

Copy link
Copy Markdown
Owner

Scope

Dead-code cleanup only, no behavior change. No helpers added.

  • server/src/migrations/1769337909811-updateImportFileMetadata.ts: removed commented-out DROP/ADD column queries.
  • server/src/reports/studentReportCardReact.tsx: removed commented-out isSpecial map block in filterReports.

Not changed (considered)

  • any in server doAction overrides: mirrors shared base signature (server/shared, other repo). Narrowing extra/filter helpers to unknown broke typecheck (getAsNumberArray, student-by-year specs), reverted.
  • doAction boilerplate: tied to shared base; DRY belongs in nra-server.

Tests

Server jest: all 1109 tests pass (117/119 suites on the full run before reverting two experimental unknown edits; affected suites re-run: 23/23 pass, 262 tests). Client untouched, not run.


Generated by Claude Code

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01XKNMkzqdCcd8QUEVXWgZY9
@buzz-code
buzz-code merged commit 8591dcb into main Oct 17, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants