Repository navigation
Exclude inactive students from attendance entry rosters - #220
Merged
buzz-code merged 2 commits intoOct 18, 2026
Merged
Conversation
Students marked inactive (left school) still appeared when entering new attendance, so teachers kept reporting on them and the Yemot seminar flow even saved them as present. Filter student.isActive = true where a roster is built for new reports: in-lesson report screen, Yemot seminar roster, and teacher report file. View/pivot reports are unchanged and keep the student's history (they already offer an "active student" filter). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HW4KhJ4NR3QPtnXXa9WwBk
…ctive-students-filter-qe0ndg # Conflicts: # client/src/roadmapFeatures.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A student marked "לא פעיל" (left school) still appeared when entering new attendance. Customer workaround was deleting her class assignments — which wipes her from
student_by_year-based pivots and loses her history.Yemot seminar flow was worse: every rostered student not keyed as absent gets saved as present, so inactive students got fake attendance rows.
Change
Filter
student.isActive = trueonly where a roster is built for new reports:client/src/reports/in-lesson-report/LessonSelector.jsx— in-lesson report screen (student_klassfetch).server/src/yemot-handler.service.ts—getKlassRoster(seminar Yemot flow).server/src/reports/teacherReportFile.ts— teacher report file.View/pivot reports untouched — history kept, they already have an "active student" filter.
Roadmap entry added (customer-visible).
Tradeoff
Retroactive reporting for a date before she left won't list her. Workaround: re-activate temporarily.
Tests
AttReportrow (verified failing without fix).teacherReportFilespec assertsisActive: truein theStudentKlassquery.🤖 Generated with Claude Code
https://claude.ai/code/session_01HW4KhJ4NR3QPtnXXa9WwBk
Generated by Claude Code