Skip to content

Exclude inactive students from attendance entry rosters - #220

Merged
buzz-code merged 2 commits into
mainfrom
claude/attendance-inactive-students-filter-qe0ndg
Oct 18, 2026
Merged

buzz-code merged 2 commits into
mainfrom
claude/attendance-inactive-students-filter-qe0ndg

Conversation

@buzz-code

Copy link
Copy Markdown
Owner

Problem

A student marked "לא פעיל" (left school) still appeared when entering new attendance. Customer workaround was deleting her class assignments — which wipes her from student_by_year-based pivots and loses her history.

Yemot seminar flow was worse: every rostered student not keyed as absent gets saved as present, so inactive students got fake attendance rows.

Change

Filter student.isActive = true only where a roster is built for new reports:

  • client/src/reports/in-lesson-report/LessonSelector.jsx — in-lesson report screen (student_klass fetch).
  • server/src/yemot-handler.service.ts — getKlassRoster (seminar Yemot flow).
  • server/src/reports/teacherReportFile.ts — teacher report file.

View/pivot reports untouched — history kept, they already have an "active student" filter.

Roadmap entry added (customer-visible).

Tradeoff

Retroactive reporting for a date before she left won't list her. Workaround: re-activate temporarily.

Tests

  • New Yemot scenario: inactive student in klass gets no AttReport row (verified failing without fix).
  • teacherReportFile spec asserts isActive: true in the StudentKlass query.
  • Server: yemot + reports suites pass (50). Client: full suite passes (241).

🤖 Generated with Claude Code

https://claude.ai/code/session_01HW4KhJ4NR3QPtnXXa9WwBk


Generated by Claude Code

Students marked inactive (left school) still appeared when entering new
attendance, so teachers kept reporting on them and the Yemot seminar flow
even saved them as present. Filter student.isActive = true where a roster
is built for new reports: in-lesson report screen, Yemot seminar roster,
and teacher report file. View/pivot reports are unchanged and keep the
student's history (they already offer an "active student" filter).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01HW4KhJ4NR3QPtnXXa9WwBk
…ctive-students-filter-qe0ndg

# Conflicts:
#	client/src/roadmapFeatures.js
@buzz-code
buzz-code merged commit 53e4753 into main Oct 18, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants