Repository navigation
Show display names in teacher-reported-today and absence tracking - #219
Merged
Merged
Conversation
Lesson, teacher and class names fall back to name when no display name is set. student_base_klass view gets a base_klass_display_name column for the absence tracking class cards. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LSyL41fKyfGybbVQ9CshnA
Replaces the client-side lesson fetch in absence tracking with the display name set on the pivot header label. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LSyL41fKyfGybbVQ9CshnA
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by הדסה · project thread
Before: the "teachers who reported attendance" report and the "absence tracking" report always showed the plain name of classes, lessons and teachers.
After: both reports show the display name when one is set, and fall back to the name otherwise. The student attendance pivot table's subject columns follow too, since they share the same pivot.
How: teacher-reported-today renders lesson, teacher and class through a
displayName || nameFunctionField. The StudentAttendance pivot labels each lesson column withdisplayName || name. Absence tracking's class cards read a newbase_klass_display_namecolumn on thestudent_base_klassview (COALESCE(NULLIF(display_name, ''), name)). Migration was generated withtypeorm:generateagainst a local MySQL, re-check shows zero diff, and revert/re-run works. Roadmap entry added.🤖 Generated with Claude Code
https://claude.ai/code/session_01LSyL41fKyfGybbVQ9CshnA