Repository navigation
Show unreported lessons in the teacher-reported-today report - #218
Merged
Merged
Conversation
Add a lessonTimes setting (lesson start/end times per group of weekdays) next to lateValue. The teacher-reported-today report maps each report to the lesson it was made in, and shows an empty slot for every lesson with no report between the first and last reported lessons of a class's day. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0174KSELfDgGPRrqq6ffo7Gw
… times Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0174KSELfDgGPRrqq6ffo7Gw
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0174KSELfDgGPRrqq6ffo7Gw
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0174KSELfDgGPRrqq6ffo7Gw
…-099uj4 # Conflicts: # client/src/roadmapFeatures.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by הדסה · project thread
Before: the teacher-reported-today report lists only lessons that were reported, so a lesson skipped in the middle of the day is invisible.
After: General settings has a new "זמני שיעורים" field next to the late value: groups of weekdays, each with a list of lesson start/end times (
TimeInput, stored as "HH:mm"). When it is set, each class card in the report shows a dashed empty slot ("שיעור 3 (09:45–10:30) לא דווח") for every lesson with no report between the first and last reported lessons of that day. Nothing is added before the first or after the last report, since the class may have started late or ended early.How:
client/src/utils/lessonGaps.jsmaps each report to the last lesson that started at or before its report time (Israel time), so a report made in the break counts for the lesson before it. Reports entered on a different day than their report date are ignored for this, since their time says nothing about the lesson. Dates are tracked separately when a date range is shown. The setting is stored inadditionalData.lessonTimesthrough the existingupdateSettings, so no server change. Empty or malformed setting means the report is unchanged. Admins see no gaps, since lesson times are the viewer's own setting.Known limit: a double lesson reported once shows an empty slot for its second half.
Tests:
lessonGaps.test.js(new), full client suite 241/241,vite buildok.🤖 Generated with Claude Code
https://claude.ai/code/session_0174KSELfDgGPRrqq6ffo7Gw