Skip to content

Show unreported lessons in the teacher-reported-today report - #218

Merged
buzz-code merged 5 commits into
mainfrom
claude/project-thread-099uj4
Oct 15, 2026
Merged

buzz-code merged 5 commits into
mainfrom
claude/project-thread-099uj4

Conversation

@buzz-code

@buzz-code buzz-code commented Oct 14, 2026 •

Copy link
Copy Markdown
Owner

Requested by הדסה · project thread

Before: the teacher-reported-today report lists only lessons that were reported, so a lesson skipped in the middle of the day is invisible.

After: General settings has a new "זמני שיעורים" field next to the late value: groups of weekdays, each with a list of lesson start/end times (TimeInput, stored as "HH:mm"). When it is set, each class card in the report shows a dashed empty slot ("שיעור 3 (09:45–10:30) לא דווח") for every lesson with no report between the first and last reported lessons of that day. Nothing is added before the first or after the last report, since the class may have started late or ended early.

How: client/src/utils/lessonGaps.js maps each report to the last lesson that started at or before its report time (Israel time), so a report made in the break counts for the lesson before it. Reports entered on a different day than their report date are ignored for this, since their time says nothing about the lesson. Dates are tracked separately when a date range is shown. The setting is stored in additionalData.lessonTimes through the existing updateSettings, so no server change. Empty or malformed setting means the report is unchanged. Admins see no gaps, since lesson times are the viewer's own setting.

Known limit: a double lesson reported once shows an empty slot for its second half.

Tests: lessonGaps.test.js (new), full client suite 241/241, vite build ok.

🤖 Generated with Claude Code

https://claude.ai/code/session_0174KSELfDgGPRrqq6ffo7Gw

Add a lessonTimes setting (lesson start/end times per group of weekdays)
next to lateValue. The teacher-reported-today report maps each report to
the lesson it was made in, and shows an empty slot for every lesson with
no report between the first and last reported lessons of a class's day.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0174KSELfDgGPRrqq6ffo7Gw
@buzz-code buzz-code self-assigned this Oct 14, 2026
… times

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0174KSELfDgGPRrqq6ffo7Gw
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0174KSELfDgGPRrqq6ffo7Gw
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0174KSELfDgGPRrqq6ffo7Gw
…-099uj4

# Conflicts:
#	client/src/roadmapFeatures.js
@buzz-code
buzz-code merged commit afb7a39 into main Oct 15, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants