Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/skills/generate-migration/SKILL.md
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,8 @@ Always pass `-p` (pretty-print) so the generated SQL is readable instead of one
NODE_ENV=development yarn typeorm:generate src/migrations/YourMigrationName -p
```

**Timestamp must be the real current time.** The `<timestamp>` prefix in the file name (and the matching suffix on the class name) must be the actual millisecond epoch at creation — what `typeorm:generate`/`migration:create` write, or `date +%s%3N` when you name a file by hand (e.g. a data-only migration). Never use a rounded/made-up value (`1787100000000`), start-of-today midnight, or `+1` on the previous migration. TypeORM orders migrations by this number, so a fake one can sort before migrations already applied in production and get skipped or run out of order. It must also be greater than every existing migration's timestamp in `server/src/migrations/`.

**Check the generated file for noise.** If an existing entity has an index/column with no explicit name, TypeORM may compute a different auto-generated hash name than what's actually stored in the DB, and your migration will include an unrelated rename alongside your real change. Strip anything not related to what you changed.

## Step 5: Verify zero diff
Expand Down
2 changes: 1 addition & 1 deletion .github/skills/yemot-integration/SKILL.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ Shared code lives in `server/shared/utils/yemot/` (`nra-server`); each project s

**Add/change a flow:** edit the project's `YemotHandlerService.processCall()` (and its private `process*Call()` helpers). Ask the user (via `this.read/send` helpers on the base) for input, validate, persist. Keep flow-specific logic in the project; only truly shared IVR mechanics go in `nra-server`.

**Menu texts** live in DB (`YemotCall`/yemot-texts) and are updated via migrations — see the `UpdateYemotTexts*` migrations in `react-admin-nestjs/server/src/migrations/`. Use `generate-migration` for schema/text changes.
**Menu texts** live in DB (`YemotCall`/yemot-texts) and are updated via migrations — see the `UpdateYemotTexts*` migrations in `react-admin-nestjs/server/src/migrations/`. Use `generate-migration` for schema/text changes; a hand-written text migration still needs a real `date +%s%3N` timestamp (see that skill).

**File upload/download to Yemot:** paths must carry the `ivr2:` scheme prefix (a past bug shipped without it). `uploadFile`/`downloadFile`/`deleteFile` live in `utils/phone/yemot-api.service.ts` — reuse them, mind the auth and path prefix.

Expand Down
Loading