Skip to content

feat(settings): let users set mail sender name and address - #216

Merged
buzz-code merged 1 commit into
mainfrom
claude/quirky-keller-if3x8d
Oct 12, 2026
Merged

buzz-code merged 1 commit into
mainfrom
claude/quirky-keller-if3x8d

Conversation

@buzz-code

Copy link
Copy Markdown
Owner

Summary

  • New "הגדרות מייל" section in settings (MailSettingsInput.jsx) with two fields:
    • sender name (mailAddressTitle)
    • sender address (mailAddressAlias), shown with an @mail.yoman.online suffix
  • Settings.jsx sends one updateProfile call containing only the changed profile fields (phoneNumber, mailAddressTitle, mailAddressAlias). It shows the server's 400 message, such as "address already taken", instead of the generic error.
  • Bumps server/shared to feat(auth): let users set mail sender name and alias via profile nra-server#70, where the profile endpoint accepts the mail fields and validates the alias against the users table and the shared n8n uniqueness check.
  • With that bump, mail now shows the sender name even when no alias is set.
  • Translations and a roadmap entry are added.

Tests

  • New src/settings/Settings.test.jsx
  • client: 37 suites, 227 tests, all passing
  • server: 118 suites, 1136 tests, all passing

🤖 Generated with Claude Code

https://claude.ai/code/session_01NXGajgLhoi2eehy1epuMpu


Generated by Claude Code

- New 'הגדרות מייל' section in settings with sender name and alias
- Settings save sends only changed profile fields to updateProfile and shows server validation errors
- Bump server/shared to nra-server#70 (profile accepts mail fields, alias validation)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NXGajgLhoi2eehy1epuMpu
@buzz-code
buzz-code merged commit 39b6002 into main Oct 12, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants