Repository navigation
feat(settings): let users set mail sender name and address - #216
Merged
Merged
Conversation
- New 'הגדרות מייל' section in settings with sender name and alias - Settings save sends only changed profile fields to updateProfile and shows server validation errors - Bump server/shared to nra-server#70 (profile accepts mail fields, alias validation) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NXGajgLhoi2eehy1epuMpu
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MailSettingsInput.jsx) with two fields:mailAddressTitle)mailAddressAlias), shown with an@mail.yoman.onlinesuffixSettings.jsxsends oneupdateProfilecall containing only the changed profile fields (phoneNumber,mailAddressTitle,mailAddressAlias). It shows the server's 400 message, such as "address already taken", instead of the generic error.server/sharedto feat(auth): let users set mail sender name and alias via profile nra-server#70, where the profile endpoint accepts the mail fields and validates the alias against the users table and the shared n8n uniqueness check.Tests
src/settings/Settings.test.jsxclient: 37 suites, 227 tests, all passingserver: 118 suites, 1136 tests, all passing🤖 Generated with Claude Code
https://claude.ai/code/session_01NXGajgLhoi2eehy1epuMpu
Generated by Claude Code