Repository navigation
Save phone transport lateness on student's morning klass - #215
Merged
Merged
Conversation
Transport lateness reported by phone was saved on an arbitrary student klass (usually the base klass). Prefer the student's current-year klass whose name starts with "בוקר"; fall back to previous behavior when none. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Rubw4xHpfDfDmWWoZSQovN
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Rubw4xHpfDfDmWWoZSQovN
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Transport lateness reported by phone (Yemot) was saved on an arbitrary student klass — in practice the base klass (כיתת אם). Customer wants it on the morning klass (e.g. "בוקר ו6").
createAbsenceRecordnow fetches the student's klasses once, then picks the current-year klass whose name starts withבוקר.STUDENT.NO_CLASShangup unchanged.Tests
yemot-handler.service.test.ts: 32/32 pass. New morning-klass test fails without the fix.Notes
Existing records are not migrated; only new phone reports are affected.
🤖 Generated with Claude Code
https://claude.ai/code/session_01Rubw4xHpfDfDmWWoZSQovN
Generated by Claude Code