Skip to content

Add bulk edit action to attendance reports - #214

Merged
buzz-code merged 4 commits into
mainfrom
claude/project-thread-fxwj6s
Oct 13, 2026
Merged

buzz-code merged 4 commits into
mainfrom
claude/project-thread-fxwj6s

Conversation

@buzz-code

@buzz-code buzz-code commented Oct 12, 2026 •

Copy link
Copy Markdown
Owner

Requested by הדסה · project thread

Before: attendance reports could be bulk-changed only by class ("שינוי כיתה") or teacher ("שינוי מורה"). A class entered on the wrong date had to be fixed row by row, so approved absences for the real date did not line up.

After: one "עריכה מרוכזת" bulk action replaces both. Its dialog has report date, class, teacher, lesson, lesson count, absences and comment. Only filled fields are updated on the selected rows; empty fields stay unchanged, and the dialog always opens empty.

Report month and Hebrew date derive from reportDate (view join / client field), so they follow automatically. Student and year are intentionally not editable here.

How: new bulkEdit case in AttReportWithReportMonthService.doAction uses the new shared getBulkEditUpdate (built on getAsNumber/getAsDate/getAsString) and runs one update on AttReport. bulkChangeKlass/bulkChangeTeacher are removed. The client button uses the new shared cacheValues={false} option. Unit tests and a roadmap entry added.

Depends on shared PRs (submodule pointers bumped to their branches; re-point to main after they merge):

🤖 Generated with Claude Code

https://claude.ai/code/session_01AfCNveaaEyDu2irhQkQ7oQ

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AfCNveaaEyDu2irhQkQ7oQ
@buzz-code buzz-code self-assigned this Oct 12, 2026
… reports

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AfCNveaaEyDu2irhQkQ7oQ
@buzz-code buzz-code changed the title Add "change date" bulk action to attendance reports Add bulk edit action to attendance reports Oct 12, 2026
…lse}

Bumps client/shared and server/shared to branches adding those helpers.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AfCNveaaEyDu2irhQkQ7oQ
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AfCNveaaEyDu2irhQkQ7oQ
@buzz-code
buzz-code marked this pull request as ready for review October 13, 2026 19:09
@buzz-code
buzz-code merged commit 1830944 into main Oct 13, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants